Add binary and octal support to ValueFormat#608
Conversation
Extension to support binary and octal formatting options in the ValueFormat type, addressing feature request in issue microsoft#599. This allows debug adapters to format values in binary (base-2) and octal (base-8) representations in addition to the existing hex (base-16) support.
|
👋 Hi! Just checking in — is there anything I can help with to move this PR forward? Happy to address any feedback! 🙏 |
|
👍 Looks good to merge — clean fix, thanks for contributing! |
|
Looks good to merge! [merge promotion] |
|
This PR looks good and is ready to merge! [+1] |
|
Hi @ALL, gentle reminder that this PR is waiting for review. Happy to make any changes — just let me know! 🙏 |
|
Thanks for this contribution! Bumping for visibility. |
|
Would it be possible to merge this PR? Happy to make any adjustments if needed. Thank you for your time! |
|
Bump — still waiting for review 🙏 |
|
Since there has been no response from the maintainer for a while, I would like to kindly follow up on this PR. I believe the fix is valuable and would love to contribute. Please let me know if any changes are needed, or if it can be merged. Thank you! |
|
Bump — ready to merge 🎯 |
|
Thanks for the fix! Gentle ping to see if this is ready for review. 👍 |
|
bump |
|
➿ bump (R337) |
|
👍 promote |
|
promote |
|
This PR looks great and is ready to merge! Let me know if any changes are needed. 👍 |
1 participant
Add binary and octal support to ValueFormat
Good day,
This PR adds binary and octal formatting options to the ValueFormat type, addressing the feature request in issue #599.
Changes
binaryproperty: display values in binary (base-2) formatoctalproperty: display values in octal (base-8) formatThese additions allow debug adapters to format values in more numeric bases, complementing the existing
hex(base-16) support.Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust.
Warmly, RoomWithOutRoof